Add the CustomTypeMarshallerAttribute type to make it easier to identify marshaller types #65591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify which types are marshaller types to make it easier to version the shape model and help users write shape types.
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsAdd a This PR also updates the design docs.
|
jkoritzinsky
force-pushed
the
custom-marshalling-v2
branch
from
8464fa2
to
3104a16
Compare
elinor-fung
reviewed
Mar 17, 2022
docs/design/libraries/LibraryImportGenerator/SpanMarshallers.md
Outdated
Show resolved
Hide resolved
docs/design/libraries/LibraryImportGenerator/SpanMarshallers.md
Outdated
Show resolved
Hide resolved
docs/design/libraries/LibraryImportGenerator/StructMarshalling.md
Outdated
Show resolved
Hide resolved
docs/design/libraries/LibraryImportGenerator/StructMarshalling.md
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Runtime/InteropServices/CustomTypeMarshallerDirection.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Runtime/InteropServices/CustomTypeMarshallerDirection.cs
Outdated
Show resolved
Hide resolved
...s/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/AnalyzerDiagnostics.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
force-pushed
the
custom-marshalling-v2
branch
from
07803e6
to
61673ac
Compare
elinor-fung
reviewed
Mar 19, 2022
src/libraries/Common/src/System/Runtime/InteropServices/GeneratedMarshallingAttribute.cs
Outdated
Show resolved
Hide resolved
docs/design/libraries/LibraryImportGenerator/StructMarshalling.md
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources.resx
Outdated
Show resolved
Hide resolved
...s/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/AnalyzerDiagnostics.cs
Outdated
Show resolved
Hide resolved
...s/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/AnalyzerDiagnostics.cs
Outdated
Show resolved
Hide resolved
...s/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/AnalyzerDiagnostics.cs
Outdated
Show resolved
Hide resolved
...s/gen/Microsoft.Interop.SourceGeneration/Marshalling/ICustomNativeTypeMarshallingStrategy.cs
Outdated
Show resolved
Hide resolved
...s/gen/Microsoft.Interop.SourceGeneration/Marshalling/ICustomNativeTypeMarshallingStrategy.cs
Show resolved
Hide resolved
This was referenced Mar 22, 2022
|
Failures are dotnet/roslyn-sdk#974, #59542, and #64964/#66852 |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test failures from the runtime-libraries-coreclr outerloop pipelines are as follows: Windows failures are due to deadlettered Helix jobs System.Security.Cryptography.X509Certificates failures are #66803 Regex failure on OSX is a timeout. Not sure what caused that. System.Runtime failures on some Linux lanes: I'll try to figure out what's causing those to fail. |
|
System.Runtime test failures look like #58616 |
elinor-fung
approved these changes
Mar 23, 2022
AaronRobinsonMSFT
approved these changes
Mar 23, 2022
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
…ify marshaller types (dotnet#65591)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
CustomTypeMarshallerAttributetype that goes on the marshaller type to enable us to easily identify marshaller types and provide an easier way for us to analyze and validate the shape of the user-defined marshaller types.This PR also updates the design docs.